Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Svg scripts #745

Merged
merged 4 commits into from
Jul 22, 2014
Merged

Svg scripts #745

merged 4 commits into from
Jul 22, 2014

Conversation

pnorman
Copy link
Collaborator

@pnorman pnorman commented Jul 20, 2014

  • By using rounded rectangles, the resulting SVG is cleaner, and easier to extend
  • The shield in the file name was redundant with the directory name
  • The new file names allow for multi-line shields, and the scripts make allowances for these
  • Using scripts makes it much easier to change all the shields at once for colour changes

These clear the way for me to work on #726 and #670 (comment)

@matthijsmelissen
Copy link
Collaborator

Is this ready to be assigned to @gravitystorm for merging?

@pnorman pnorman assigned gravitystorm and unassigned pnorman Jul 20, 2014
@pnorman pnorman mentioned this pull request Jul 21, 2014
Merged
@gravitystorm gravitystorm merged commit 82602e3 into gravitystorm:master Jul 22, 2014
@pnorman pnorman deleted the svg_scripts branch July 22, 2014 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gravitystorm gravitystorm

Labels
amenity-points
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pnorman @matthijsmelissen @gravitystorm